Helpful mindset shift: Approach code review comments as a help.

I noticed that I could react defensively if my code review request is not approved straight away and some code changes are suggested.
That is understandable; I usually spend quite a lot of time making sure I understand the problem and provide a good enough solution within the technological and time constraints I have.
So, when someone suggests changes, it is easy to feel unappreciated.
Regardless of the fact if you are unappreciated or not, it is still better to approach any comments and suggestions as indications of potential improvement areas:
Try to understand what is actually being suggested.
If it doesn't make sense, ask for clarification.
Remember that you can always push back.
Bonus tip:
You should not really worry if it takes hours or days for the review to complete. If you think it takes too long, communicate it to the people responsible for the process and let them suggest changes.
Back and forth on MRs is part of your work.
What do you think?
Subscribe to my newsletter
Read articles from Alexander Pushkarev directly inside your inbox. Subscribe to the newsletter, and don't miss out.
Written by

Alexander Pushkarev
Alexander Pushkarev
With more than 10 years in IT, I had a chance to work in different areas, such as development, testing and management. I had a chance to work with PHP, Java, Python and .Net platforms with different application from microservices to monolithic and monstrous desktop UI applications. Currently, I am holding the position of Senior Software Engineer, but I prefer to consider myself a full-stack engineer. My passions are quality and efficiency. Agile fan and XP practitioner.